Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Deleted profile name updated only after refresh #3823

Merged
merged 1 commit into from
Jul 1, 2021
Merged

Fix: Deleted profile name updated only after refresh #3823

merged 1 commit into from
Jul 1, 2021

Conversation

rdjuric
Copy link
Contributor

@rdjuric rdjuric commented Jun 30, 2021

Details

Fixes an issue where deleting our name would only take effect after a refresh. This happened

Fixed Issues

#3778

Tests

  1. Your profile has a first or/and last name
  2. Delete both your first and last name
  3. Save the change
  4. The change is reflected in the UX immediately

QA Steps

  1. Your profile has a first or/and last name
  2. Delete both your first and last name
  3. Save the change
  4. The change should be reflected in the UX immediately

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

web.mov

Mobile Web

mWeb.mp4

Desktop

desktop.mov

iOS

iOS.mp4

Android

android.mp4

@rdjuric rdjuric requested a review from a team as a code owner June 30, 2021 14:57
@MelvinBot MelvinBot requested review from Jag96 and removed request for a team June 30, 2021 14:57
Jag96
Jag96 approved these changes Jul 1, 2021
View reviewed changes
Copy link
Contributor

@Jag96 Jag96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jag96 Jag96 merged commit 72dc183 into Expensify:main Jul 1, 2021
@OSBotify
Copy link
Contributor

OSBotify commented Jul 1, 2021

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify OSBotify mentioned this pull request Jul 7, 2021
Closed
57 tasks
@roryabraham
Copy link
Contributor

Unfortunately the deploy comments are not working right now. This was deployed to staging yesterday.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jag96 Jag96 Jag96 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rdjuric @OSBotify @roryabraham @Jag96